optimize getBiz method by reduce invoke Map.toArray() (#1286)

sofastack / sofa-boot

SOFABoot is a framework that enhances Spring Boot and fully compatible with it, provides readiness check, class isolation, etc.

https://www.sofastack.tech/sofa-boot/docs/Home

Apache License 2.0

4.92k stars 1.26k forks source link

optimize getBiz method by reduce invoke Map.toArray() (#1286) #1287

Closed NTP1996 closed 4 months ago

NTP1996 commented 5 months ago

使用getBizByClassLoader 方法替换getBizInOrder方法。减少 Map.toArray 调用次数，和冗余的排序操作；

sofastack-cla[bot] commented 5 months ago

Hi @NTP1996, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

NTP1996 commented 5 months ago

请 @HzjNeverStop 帮忙 review 下，看是否 ok。解决 #1286 ，非常感谢。

HzjNeverStop commented 4 months ago

请 @HzjNeverStop 帮忙 review 下，看是否 ok。解决 #1286 ，非常感谢。

修改方式没有问题，请修改测试用例 DynamicJvmServiceProxyFinderTests 以通过 CI

NTP1996 commented 4 months ago

请 @HzjNeverStop 帮忙 review 下，看是否 ok。解决 #1286 ，非常感谢。

修改方式没有问题，请修改测试用例 DynamicJvmServiceProxyFinderTests 以通过 CI

已修改

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c050784) 82.95% compared to head (ce9a380) 82.98%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1287 +/- ## ============================================ + Coverage 82.95% 82.98% +0.02% - Complexity 2916 2925 +9 ============================================ Files 330 330 Lines 9620 9625 +5 Branches 1164 1164 ============================================ + Hits 7980 7987 +7 Misses 1131 1131 + Partials 509 507 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.