Closed HzjNeverStop closed 3 months ago
The update in the DynamicJvmServiceInvoker
class signifies a shift towards a simpler, more direct approach in handling class loaders. By transitioning from a ThreadLocal
to a direct ClassLoader
field for clientClassloader
, the codebase leans towards straightforwardness. This change not only streamlines the class loader usage but also eliminates the need for additional methods managing the ThreadLocal
, thereby simplifying the code structure.
File Path | Change Summary |
---|---|
.../ark-sofa-boot/src/main/java/com/alipay/sofa/boot/ark/invoke/DynamicJvmServiceInvoker.java |
Replaced ThreadLocal with direct ClassLoader field; updated method invocations; removed ThreadLocal management methods. |
🐇✨
In the realm of code, where changes abide,
A rabbit hopped, with a joyful stride.
"Away with complexity, let simplicity guide,"
It cheered, asThreadLocal
was set aside.
Now, with direct paths, we glide!
🌟🐾
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 83.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 83.04%. Comparing base (
2e8af92
) to head (475ce39
).
Files | Patch % | Lines |
---|---|---|
...sofa/boot/ark/invoke/DynamicJvmServiceInvoker.java | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by CodeRabbit
ClassLoader
.