Closed CrazyHZM closed 1 month ago
The recent changes enhance the shutdown process of SofaRuntimeManager
in SofaRuntimeContainer
and SofaBizUninstallEventHandler
. SofaRuntimeContainer
now ensures proper shutdown of SofaRuntimeManager
before removal, while SofaBizUninstallEventHandler
includes a null check before external shutdown.
File Path | Change Summary |
---|---|
.../SofaRuntimeContainer.java |
Enhanced destroy method to safely shut down SofaRuntimeManager before removal from the map. |
.../SofaBizUninstallEventHandler.java |
Modified doUninstallBiz method to include a null check before shutting down SofaRuntimeManager . |
.../SofaRuntimeContainerTests.java , .../SofaBizUninstallEventHandlerTests.java |
Test methods and assertions related to SofaRuntimeManager handling were updated or removed. |
In the realm of code, where logic flows, A rabbit hops and swiftly knows, To shut down right, avoid the plight, Ensuring managers sleep tight. With checks in place, no errors trace, The system's grace, a smoother pace.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.12%. Comparing base (
b78f29d
) to head (355fedc
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
@HzjNeverStop 你好,合并后可以构建下并部署到mvnrepository仓库吗,似乎现在的还是之前的
see https://github.com/sofastack/sofa-boot/issues/1321
Summary by CodeRabbit
SofaRuntimeManager
to ensure it is properly shut down before removal.sofaRuntimeManager
is not null before shutting it down.