search

sofastack / sofa-dashboard-client

Apache License 2.0
16 stars 25 forks source link

Split zookeeper client with publisher #26

Closed chpengzh closed 4 years ago

chpengzh commented 5 years ago
sofastack-bot[bot] commented 5 years ago

Hi @chpengzh, we detect non-English characters in the issue. This comment is an auto translation by @sofastack-robot to help other users to understand this issue.

We encourage you to describe your issue in English which is more friendly to other users.

codecov-io commented 5 years ago

Codecov Report

Merging #26 into master will increase coverage by 6.55%. The diff coverage is 70.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   71.53%   78.09%   +6.55%     
==========================================
  Files          33       34       +1     
  Lines         822      849      +27     
  Branches       52       53       +1     
==========================================
+ Hits          588      663      +75     
+ Misses        204      148      -56     
- Partials       30       38       +8
Impacted Files Coverage Δ
.../alipay/sofa/dashboard/client/utils/JsonUtils.java 19.44% <ø> (+3.44%) :arrow_up:
.../client/registry/zookeeper/ZookeeperConstants.java 0% <0%> (ø) :arrow_up:
...fa/dashboard/client/zookeeper/ZookeeperConfig.java 100% <100%> (ø)
...a/dashboard/client/ark/ArkBizLifecycleHandler.java 48.57% <48.57%> (ø)
...a/dashboard/client/zookeeper/LifecycleHandler.java 66.66% <66.66%> (ø)
...ient/registry/zookeeper/ZookeeperAppPublisher.java 68.51% <72.72%> (+12.51%) :arrow_up:
...ent/registry/zookeeper/ZookeeperRegistryUtils.java 80.48% <75%> (ø)
...fa/dashboard/client/zookeeper/ZookeeperClient.java 76.92% <76.92%> (ø)
...ent/registry/zookeeper/ZookeeperAppSubscriber.java 83.33% <90.32%> (+7.33%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0747fa1...7a0d9e9. Read the comment docs.