sofastack / sofa-jarslink

Jarslink is a sofa ark plugin used to manage multi-application deployment
Apache License 2.0
3.04k stars 706 forks source link

Joe #22

Closed JoeKerouac closed 6 years ago

JoeKerouac commented 6 years ago

更改了基础代码的代码风格,将Action调用处的异常捕获由Exception更改为了Throwable,将一个方法提取为公共方法(原方法为各个类中私有,更改后仅包内可访问,作用域对于框架使用者来说基本不变)

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 28


Changes Missing Coverage Covered Lines Changed/Added Lines %
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/AbstractModuleRefreshScheduler.java 9 10 90.0%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/ModuleLoaderImpl.java 14 15 93.33%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/SpringModule.java 1 2 50.0%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/ModuleTools.java 7 10 70.0%
<!-- Total: 39 45 86.67% -->
Totals Coverage Status
Change from base Build 22: 0.6%
Covered Lines: 324
Relevant Lines: 376

💛 - Coveralls
kiral commented 6 years ago

感谢你的提交!框架需要兼容低版本,不能用JDK1.8的新特性,很多系统目前还是JDK1.5和1.6。

JoeKerouac commented 6 years ago

好吧,我是有看到pom里边写java版本号是1.8所以就用了1.8改了下= =||

JoeKerouac commented 6 years ago

感谢您的回复