sofastack / sofa-jarslink

Jarslink is a sofa ark plugin used to manage multi-application deployment
Apache License 2.0
3.04k stars 706 forks source link

模块生命周期监听,添加spring mvc集成支持 #64

Closed liangruisen closed 6 years ago

liangruisen commented 6 years ago

Support for #1.6.1.20180301 ,Fix #24 #30 #38 #57

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 111


Changes Missing Coverage Covered Lines Changed/Added Lines %
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/SpringModule.java 62 69 89.86%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/ModuleManagerImpl.java 82 107 76.64%
jarslink-api/src/main/java/com/alipay/jarslink/api/impl/SpringModuleRequestMappingHandlerMapping.java 0 69 0.0%
<!-- Total: 144 245 58.78% -->
Totals Coverage Status
Change from base Build 97: -13.0%
Covered Lines: 470
Relevant Lines: 621

💛 - Coveralls
JoeKerouac commented 6 years ago

请先完善一下单元测试(按照标准如何贡献代码进行),然后生命周期监听可以作为核心模块的功能,springMVC的支持建议作为一个单独的子模块来单独支持,参照1.7分支中的模块调用功能。