sofastack / sofa-registry

SOFARegistry is a production-level, low-latency, high-availability service registry powered by Ant Financial.
https://www.sofastack.tech/sofa-registry/docs/Home
Apache License 2.0
653 stars 247 forks source link

Explicitly specify spring-boot-maven-plugin version #255

Closed liqipeng closed 2 years ago

liqipeng commented 2 years ago

Motivation:

I encountered this error while building on a laptop:

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4:repackage (default) on project registry-server-session: Execution default of goal org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4:repackage failed: Unable to load the mojo 'repackage' in the plugin 'org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/springframework/boot/maven/RepackageMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Modification:

Explicitly specify spring-boot-maven-plugin version

( This error not encountered on another PC. It is odd and it may be environmental. And I think it will not introduce negative effect when explicitly specify spring-boot-maven-plugin version. )

Result:

Keep the spring-boot-maven-plugin version same to spring boot.

NickNYU commented 2 years ago

Motivation:

I encountered this error while building on a laptop:

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4:repackage (default) on project registry-server-session: Execution default of goal org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4:repackage failed: Unable to load the mojo 'repackage' in the plugin 'org.springframework.boot:spring-boot-maven-plugin:3.0.0-M4' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/springframework/boot/maven/RepackageMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Modification:

Explicitly specify spring-boot-maven-plugin version

( This error not encountered on another PC. It is odd and it may be environmental. And I think it will not introduce negative effect when explicitly specify spring-boot-maven-plugin version. )

Result:

Keep the spring-boot-maven-plugin version same to spring boot.

Nice shoot The problem here, seems like you are holding a higher JDK version (say, JDK 11 maybe) in your own laptop, while we meant to compile this project on JDK8.

codecov[bot] commented 2 years ago

Codecov Report

Merging #255 (fd19cd4) into master (b802ace) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage     76.60%   76.60%           
  Complexity       48       48           
=========================================
  Files           439      439           
  Lines         15471    15471           
  Branches       1505     1505           
=========================================
  Hits          11852    11852           
  Misses         2958     2958           
  Partials        661      661           
Impacted Files Coverage Δ
...ofa/registry/server/session/store/DataIndexer.java 82.25% <0.00%> (-3.23%) :arrow_down:
...stry/server/session/store/AbstractDataManager.java 79.04% <0.00%> (+1.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b802ace...fd19cd4. Read the comment docs.