search

sofastack / sofa-registry

SOFARegistry is a production-level, low-latency, high-availability service registry powered by Ant Financial.
https://www.sofastack.tech/sofa-registry/docs/Home
Apache License 2.0
653 stars 247 forks source link

chore: add pmd unusedcode #259

Closed dzdx closed 2 years ago

dzdx commented 2 years ago

Motivation:

Explain the context, and why you're making that change. To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

codecov[bot] commented 2 years ago

Codecov Report

Merging #259 (6ca4001) into master (51c2f74) will decrease coverage by 0.00%. The diff coverage is 80.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
- Coverage     76.60%   76.60%   -0.01%     
  Complexity       48       48              
============================================
  Files           439      440       +1     
  Lines         15475    15522      +47     
  Branches       1505     1510       +5     
============================================
+ Hits          11855    11891      +36     
- Misses         2961     2967       +6     
- Partials        659      664       +5
Impacted Files Coverage Δ
...y/sofa/registry/server/session/push/PushTrace.java 68.06% <ø> (ø)
...dbc/repository/impl/AppRevisionJdbcRepository.java 69.15% <ø> (-0.57%) :arrow_down:
...ry/jdbc/repository/impl/DateNowJdbcRepository.java 89.47% <ø> (ø)
...ion/providedata/AppRevisionWriteSwitchService.java 66.66% <66.66%> (ø)
...try/jdbc/convertor/AppRevisionDomainConvertor.java 73.77% <88.00%> (+7.98%) :arrow_up:
...egistry/common/model/constants/ValueConstants.java 93.33% <100.00%> (+0.31%) :arrow_up:
...y/sofa/registry/jdbc/domain/AppRevisionDomain.java 100.00% <100.00%> (ø)
...ta/lease/impl/DefaultCrossDcMetaServerManager.java 84.61% <0.00%> (-1.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 746ab56...6ca4001. Read the comment docs.