Closed huanglongchao closed 1 year ago
Merging #319 (a984666) into master (c9cbee4) will increase coverage by
0.17%
. The diff coverage is82.71%
.
@@ Coverage Diff @@
## master #319 +/- ##
============================================
+ Coverage 76.40% 76.58% +0.17%
Complexity 48 48
============================================
Files 493 497 +4
Lines 18249 18524 +275
Branches 1783 1811 +28
============================================
+ Hits 13943 14186 +243
- Misses 3502 3519 +17
- Partials 804 819 +15
Impacted Files | Coverage Δ | |
---|---|---|
.../registry/server/session/push/FirePushService.java | 57.26% <0.00%> (-0.26%) |
:arrow_down: |
...ofa/registry/server/session/push/RegProcessor.java | 82.88% <30.76%> (-7.12%) |
:arrow_down: |
...fa/registry/server/session/push/PushProcessor.java | 78.03% <69.23%> (-0.74%) |
:arrow_down: |
...common/model/metaserver/DataChangeMergeConfig.java | 62.50% <75.00%> (ø) |
|
...a/registry/server/session/push/PushTaskBuffer.java | 76.85% <78.57%> (+<0.01%) |
:arrow_up: |
...stry/server/data/change/DataChangeEventCenter.java | 92.79% <81.03%> (-2.71%) |
:arrow_down: |
...rovidedata/FetchDataChangeMergerConfigService.java | 83.33% <83.33%> (ø) |
|
.../registry/server/session/push/ChangeProcessor.java | 90.38% <85.71%> (-0.83%) |
:arrow_down: |
.../providedata/FetchPushEfficiencyConfigService.java | 87.50% <87.50%> (ø) |
|
...rver/session/push/PushEfficiencyImproveConfig.java | 90.00% <90.00%> (ø) |
|
... and 4 more |
... and 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7aee475...a984666. Read the comment docs.
DataChangeEventCenter 同时支持session/data 数据变化通知,目前if/else有点复杂,需要重构下。本次mr取消
Motivation:
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.