search

sofastack / sofa-rpc-boot-projects

SOFABoot projects for SOFARPC, include starter and samples.
https://github.com/sofastack/sofa-rpc
Apache License 2.0
292 stars 117 forks source link

Add parameters support #160

Closed ScienJus closed 5 years ago

ScienJus commented 5 years ago

Result:

Fixes https://github.com/alipay/sofa-rpc-boot-projects/issues/136

If there is no issue then describe the changes introduced by this PR.

codecov[bot] commented 5 years ago

Codecov Report

Merging #160 into 5.x will increase coverage by 2.06%. The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x     #160      +/-   ##
============================================
+ Coverage     55.85%   57.92%   +2.06%     
- Complexity      408      426      +18     
============================================
  Files            56       56              
  Lines          1794     1818      +24     
  Branches        316      322       +6     
============================================
+ Hits           1002     1053      +51     
+ Misses          605      572      -33     
- Partials        187      193       +6
Impacted Files Coverage Δ Complexity Δ
...c/boot/runtime/binding/RpcBindingXmlConstants.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...t/runtime/adapter/helper/ConsumerConfigHelper.java 54.05% <50%> (ø) 14 <0> (ø) :arrow_down:
...pc/boot/runtime/converter/RpcBindingConverter.java 55.41% <84%> (+11.43%) 34 <5> (+11) :arrow_up:
...y/sofa/rpc/boot/runtime/param/RpcBindingParam.java 40.71% <0%> (+1.42%) 44% <0%> (+1%) :arrow_up:
...fa/rpc/boot/container/RegistryConfigContainer.java 50% <0%> (+3.44%) 10% <0%> (+1%) :arrow_up:
...t/runtime/adapter/helper/ProviderConfigHelper.java 49.33% <0%> (+4%) 7% <0%> (+2%) :arrow_up:
...ay/sofa/rpc/boot/config/LocalFileConfigurator.java 92.85% <0%> (+14.28%) 7% <0%> (+2%) :arrow_up:
...c/boot/runtime/converter/BoltBindingConverter.java 100% <0%> (+30.76%) 7% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb30f2b...78889be. Read the comment docs.