sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.82k stars 1.17k forks source link

sub unSub and unRegister request add ProtocolType #1190

Closed EvenLjj closed 2 years ago

EvenLjj commented 2 years ago

Motivation:

In MeshRegistry pub has already set protocol to request args, but unPub、sub and unSub do not set protocol to request args. Maybe when do not set protocal use default protocol, should set the protocal args for support other protocol.

Modification:

Sub、UnSub and UnPub Set protocal in request args.

Result:

If there is no issue then describe the changes introduced by this PR.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1190 (151f507) into master (9c56f7f) will increase coverage by 0.06%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1190      +/-   ##
============================================
+ Coverage     71.57%   71.64%   +0.06%     
  Complexity      828      828              
============================================
  Files           408      408              
  Lines         17211    17211              
  Branches       2682     2682              
============================================
+ Hits          12318    12330      +12     
+ Misses         3525     3518       -7     
+ Partials       1368     1363       -5     
Impacted Files Coverage Δ
...y/sofa/rpc/server/rest/SofaRestRequestHandler.java 51.66% <0.00%> (-3.34%) :arrow_down:
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.76% <0.00%> (+0.25%) :arrow_up:
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) :arrow_up:
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) :arrow_up:
...om/alipay/sofa/rpc/server/triple/TripleServer.java 75.00% <0.00%> (+1.11%) :arrow_up:
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 69.59% <0.00%> (+4.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c56f7f...151f507. Read the comment docs.