扩展点存在重复加载的问题

sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.

https://www.sofastack.tech/sofa-rpc/docs/Home

Apache License 2.0

3.81k stars 1.17k forks source link

扩展点存在重复加载的问题 #1212

Closed crazyStar00 closed 1 year ago

crazyStar00 commented 2 years ago

Describe the bug

当扩展点设置@AutoActive(providerSide = true)会自动激活，然后又通过setFilterRef配置了相同的扩展点，在FilterChain中就会有两个相同的过滤器。

Environment

SOFARPC version:5.8.2
JVM version (e.g. java -version):1.8
OS version (e.g. uname -a):Darwin 192.168.0.101 19.6.0 Darwin Kernel Version 19.6.0: Thu Oct 29 22:56:45 PDT 2020; root:xnu-6153.141.2.2~1/RELEASE_X86_64 x86_64
Maven version:3.8.3
IDE version:idea2021.3

JervyShi commented 2 years ago

This is by design. If the user actively passes in a Filter instance, we should trust the user's settings.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.