sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

support eager thread pool #1230

Closed OrezzerO closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #1230 (6ebf72e) into master (cf4445a) will increase coverage by 0.02%. The diff coverage is 84.09%.

@@             Coverage Diff              @@
##             master    #1230      +/-   ##
============================================
+ Coverage     72.02%   72.04%   +0.02%     
+ Complexity      780      779       -1     
============================================
  Files           410      414       +4     
  Lines         17375    17417      +42     
  Branches       2703     2705       +2     
============================================
+ Hits          12514    12548      +34     
- Misses         3479     3484       +5     
- Partials       1382     1385       +3     
Impacted Files Coverage Δ
...lipay/sofa/rpc/thread/EagerThreadPoolExecutor.java 60.00% <60.00%> (ø)
...lipay/sofa/rpc/thread/EagerThreadPoolSupplier.java 80.00% <80.00%> (ø)
.../java/com/alipay/sofa/rpc/server/BusinessPool.java 90.00% <100.00%> (+4.28%) :arrow_up:
...lipay/sofa/rpc/thread/FixedThreadPoolSupplier.java 100.00% <100.00%> (ø)
...ain/java/com/alipay/sofa/rpc/thread/TaskQueue.java 100.00% <100.00%> (ø)
...m/alipay/sofa/rpc/common/config/RpcConfigKeys.java 93.75% <100.00%> (+0.41%) :arrow_up:
...sian/MultipleClassLoaderSofaSerializerFactory.java 86.66% <0.00%> (-6.67%) :arrow_down:
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 87.30% <0.00%> (-1.59%) :arrow_down:
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <0.00%> (-1.07%) :arrow_down:
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

OrezzerO commented 1 year ago

I think eager thread pool has same affect to set core size equals to max size. So it is not necessary to implement eager thread pool. If you have some cases which must use eager thread pool, feel free to open this PR and @me.