sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

Exception not logged when get connection throw exception #1239

Closed MingJunDuan closed 1 year ago

MingJunDuan commented 1 year ago

Describe the bug

Actually, this is not a bug. In our pro environment, we find lots of 'get connection failed in url' log in transport.log file, but we can't figure out what exception it is because the exception is not logged, as blow: ReuseBoltClientConnectionManager.java try { connection = rpcClient.getConnection(url, url.getConnectTimeout()); } catch (Exception e) { LOGGER.warn("get connection failed in url," + url); }

Suggestion: log the exception cause we don't know what happen without enough exception info.

Expected behavior

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

EvenLjj commented 1 year ago

If it is helpful for troubleshooting, detailed logs can be added.

MingJunDuan commented 1 year ago

PR #1243

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.