sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

feat: add more parameters to nacosConfig, then you can pass usr/pwd p… #1242

Closed colin-lee closed 1 year ago

colin-lee commented 1 year ago

when nacos-registry enable auth,it will fail when register service.

Motivation:

bypass username/password parameters to nacosConfig

please specify it in application.properties

com.alipay.sofa.rpc.registry.address=nacos://172.31.101.100:8848,172.31.101.101:8848,172.31.101.102:8848/fxiaoke?username=xxxx&password=yyyy

sofastack-bot[bot] commented 1 year ago

Hi @colin-lee, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1242 (4a6cf93) into master (169016c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1242      +/-   ##
============================================
- Coverage     72.04%   72.02%   -0.02%     
  Complexity      779      779              
============================================
  Files           410      410              
  Lines         17376    17378       +2     
  Branches       2703     2703              
============================================
- Hits          12519    12517       -2     
- Misses         3475     3479       +4     
  Partials       1382     1382              
Impacted Files Coverage Δ
.../java/com/alipay/sofa/rpc/common/RpcConstants.java 100.00% <ø> (ø)
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
...ipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java 76.19% <100.00%> (+0.17%) :arrow_up:
...ofa/rpc/registry/consul/HealthServiceInformer.java 84.78% <0.00%> (-4.35%) :arrow_down:
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) :arrow_down:
...om/alipay/sofa/rpc/server/triple/TripleServer.java 74.86% <0.00%> (-1.07%) :arrow_down:
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.76% <0.00%> (+0.25%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.