Closed rickey17 closed 1 year ago
Hi @rickey17, welcome to SOFAStack community, Please sign Contributor License Agreement!
After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.
Hi @rickey17, welcome to SOFAStack community, Please sign Contributor License Agreement!
After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.
@rickey17 Some test case failed, please take a look.
Merging #1259 (8b2ab04) into master (dabc7b8) will increase coverage by
0.06%
. The diff coverage is90.76%
.
@@ Coverage Diff @@
## master #1259 +/- ##
============================================
+ Coverage 72.14% 72.21% +0.06%
Complexity 780 780
============================================
Files 411 412 +1
Lines 17418 17465 +47
Branches 2714 2723 +9
============================================
+ Hits 12567 12612 +45
+ Misses 3466 3465 -1
- Partials 1385 1388 +3
Impacted Files | Coverage Δ | |
---|---|---|
...essian/SingleClassLoaderSofaSerializerFactory.java | 73.46% <68.75%> (-2.29%) |
:arrow_down: |
...an/serialize/GenericCustomThrowableDeterminer.java | 93.33% <93.33%> (ø) |
|
...nericMultipleClassLoaderSofaSerializerFactory.java | 100.00% <100.00%> (ø) |
|
...GenericSingleClassLoaderSofaSerializerFactory.java | 89.28% <100.00%> (+13.28%) |
:arrow_up: |
...ssian/serialize/SofaResponseHessianSerializer.java | 84.31% <100.00%> (+0.31%) |
:arrow_up: |
...m/alipay/sofa/rpc/common/config/RpcConfigKeys.java | 95.83% <100.00%> (+2.50%) |
:arrow_up: |
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java | 80.00% <0.00%> (-4.00%) |
:arrow_down: |
...pay/sofa/rpc/transport/ClientTransportFactory.java | 76.92% <0.00%> (-1.54%) |
:arrow_down: |
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java | 88.88% <0.00%> (-1.24%) |
:arrow_down: |
...lipay/sofa/rpc/message/AbstractResponseFuture.java | 56.14% <0.00%> (-0.88%) |
:arrow_down: |
... and 3 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Motivation:
解决一个issue问题
https://github.com/sofastack/sofa-rpc/issues/1258
Modification:
增加sofaconfig配置sofa.rpc.generic.throw.exception,可以解决这个问题;不增加的话,保持之前的行为不变化