Closed JoeCqupt closed 1 year ago
Can we combine prometheus with grafana ? And provide a config for that . So that users can easily use sofarpc with prometheus.
Another question, how can we open or close this feature ?
Another question, how can we open or close this feature ?
// use Prometheus-client defaultRegistry for example
CollectorRegistry registry = CollectorRegistry.defaultRegistry;
SofaRpcMetricsCollector collector = new SofaRpcMetricsCollector();
// register collector to open this feature
registry.register(collector);
// unregister collector to close this feature
registry.unregister(collector);
Merging #1280 (c91820f) into master (2a0556d) will increase coverage by
0.08%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1280 +/- ##
============================================
+ Coverage 71.93% 72.02% +0.08%
- Complexity 780 783 +3
============================================
Files 413 414 +1
Lines 17555 17565 +10
Branches 2739 2740 +1
============================================
+ Hits 12629 12652 +23
+ Misses 3532 3521 -11
+ Partials 1394 1392 -2
Impacted Files | Coverage Δ | |
---|---|---|
.../main/java/com/alipay/sofa/rpc/common/Version.java | 100.00% <ø> (ø) |
|
...ansport/bolt/ReuseBoltClientConnectionManager.java | 69.56% <0.00%> (-2.90%) |
:arrow_down: |
...alipay/sofa/rpc/codec/protobuf/ProtobufHelper.java | 77.08% <0.00%> (-2.09%) |
:arrow_down: |
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java | 84.90% <0.00%> (-1.89%) |
:arrow_down: |
.../rpc/bootstrap/triple/TripleConsumerBootstrap.java | 100.00% <0.00%> (ø) |
|
...rpc/bootstrap/triple/TripleClientProxyInvoker.java | 100.00% <0.00%> (ø) |
|
...va/com/alipay/sofa/rpc/client/AbstractCluster.java | 71.54% <0.00%> (+0.52%) |
:arrow_up: |
...ofa/rpc/tracer/sofatracer/TripleTracerAdapter.java | 61.31% <0.00%> (+0.57%) |
:arrow_up: |
...pay/sofa/rpc/config/ConfigUniqueNameGenerator.java | 94.44% <0.00%> (+0.69%) |
:arrow_up: |
...lipay/sofa/rpc/message/AbstractResponseFuture.java | 57.01% <0.00%> (+0.87%) |
:arrow_up: |
... and 5 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Motivation:
885
Modification:
metrics support prometheus
Result:
Fixes #885