sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

fix: bolt swagger class not found error #1310

Closed Lo1nt closed 1 year ago

Lo1nt commented 1 year ago

Motivation:

Current swagger-core 1.5.8 depends on jackson-databind 2.9.x.

While the whole project use jackson-databind 2.13.x, and there is incompatible changes from 2.9.x to 2.13.x which introduce bugs applying swagger-core.

Modification:

let objectweb asm to be included upgrade io.swagger series to 1.6.9

Result:

Fixes #1300 https://github.com/sofastack/sofa-boot/issues/1061

codecov[bot] commented 1 year ago

Codecov Report

Merging #1310 (e2e4300) into master (75bc1ff) will increase coverage by 0.03%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
+ Coverage     71.97%   72.01%   +0.03%     
- Complexity      783      785       +2     
============================================
  Files           415      415              
  Lines         17651    17651              
  Branches       2753     2753              
============================================
+ Hits          12705    12711       +6     
+ Misses         3538     3537       -1     
+ Partials       1408     1403       -5     
Impacted Files Coverage Δ
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) :arrow_down:
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 82.40% <0.00%> (+0.92%) :arrow_up:
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0.00%> (+1.53%) :arrow_up:
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (+1.58%) :arrow_up:
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java 75.00% <0.00%> (+2.50%) :arrow_up:
...ansport/bolt/ReuseBoltClientConnectionManager.java 72.46% <0.00%> (+4.34%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.