Closed pandalee99 closed 5 months ago
Hi @pandalee99, welcome to SOFAStack community, Please sign Contributor License Agreement!
After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.
this error in :
[INFO] sofa-rpc-test-integration .......................... FAILURE [06:21 min]
But I haven't touched this module, so there shouldn't be an error. Why? I don't understand.
The unit test is a bit unstable, it needs to be addressed later, for now let's try to solve it with a retry.
maybe,this can be review or approve
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
1e99afb
) 72.01% compared to head (e373752
) 71.99%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation:
i try to add a serializer to the project. Combined with the cases provided by the project, I tried to combine them together
Modification:
the style of the code borrows from other style of the serializers. In the project ,there is also a test case attached.
Result:
Fixes #1346 .
If there are any problems with the code, please give me a hint. thanks!