sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

add fury serializer #1348

Closed pandalee99 closed 5 months ago

pandalee99 commented 11 months ago

Motivation:

i try to add a serializer to the project. Combined with the cases provided by the project, I tried to combine them together

Modification:

the style of the code borrows from other style of the serializers. In the project ,there is also a test case attached.

Result:

Fixes #1346 .

If there are any problems with the code, please give me a hint. thanks!

sofastack-cla[bot] commented 11 months ago

Hi @pandalee99, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

pandalee99 commented 11 months ago

this error in :

[INFO] sofa-rpc-test-integration .......................... FAILURE [06:21 min]

But I haven't touched this module, so there shouldn't be an error. Why? I don't understand.

EvenLjj commented 11 months ago

The unit test is a bit unstable, it needs to be addressed later, for now let's try to solve it with a retry.

pandalee99 commented 11 months ago

maybe,this can be review or approve

codecov[bot] commented 11 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1e99afb) 72.01% compared to head (e373752) 71.99%.

Files Patch % Lines
.../rpc/codec/common/BlackAndWhiteListFileLoader.java 47.05% 16 Missing and 2 partials :warning:
.../com/alipay/sofa/rpc/codec/AbstractSerializer.java 71.42% 1 Missing and 1 partial :warning:
...ay/sofa/rpc/codec/common/SerializeCheckStatus.java 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1348 +/- ## ============================================ - Coverage 72.01% 71.99% -0.03% Complexity 784 784 ============================================ Files 416 417 +1 Lines 17661 17709 +48 Branches 2752 2760 +8 ============================================ + Hits 12719 12750 +31 - Misses 3538 3554 +16 - Partials 1404 1405 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.