search

sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.16k forks source link

[WIP] Support customer exception #1411

Closed wangchengming666 closed 1 week ago

wangchengming666 commented 2 months ago

Motivation:

Explain the context, and why you're making that change. To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The updates introduce handling and configuration for user-defined exceptions within the SOFARPC framework. This allows for custom exceptions to be specified for retry logic, enhancing flexibility for business applications to manage retries based on specific needs.

Changes

File Path Change Summary
.../client/FailoverCluster.java Added handling for user-defined exceptions in retry logic.
.../common/RpcOptions.java
.../config/ConsumerConfig.java		 Introduced handling and configuration for a new field customerExceptions.
.../common/rpc-config-default.json Added new configuration for user-defined exception collection.
.../core/exception/RpcErrorType.java Added a new constant to represent user-defined exceptions.

Possibly related issues

🐇✨ A hop, a skip, in the code we weave, Now custom troubles, you can relieve. Retry, retry, with exceptions you choose, SOFARPC adapts, you no longer lose. 🌟🐰

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between f4a18df07fcd4cb99bc68725ee6eba0f9ae5ce65 and 2812056e12e10e2c0b40169e2d4577b0bb661010.
Files selected for processing (5) * core-impl/client/src/main/java/com/alipay/sofa/rpc/client/FailoverCluster.java (2 hunks) * core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1 hunks) * core/api/src/main/java/com/alipay/sofa/rpc/config/ConsumerConfig.java (3 hunks) * core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json (1 hunks) * core/exception/src/main/java/com/alipay/sofa/rpc/core/exception/RpcErrorType.java (1 hunks)
Additional comments not posted (5)
core/exception/src/main/java/com/alipay/sofa/rpc/core/exception/RpcErrorType.java (1)
`109-109`: The addition of `CUSTOMER_DESIGN_ERROR` with value 310 is correctly implemented and follows the existing naming and coding conventions.
core-impl/client/src/main/java/com/alipay/sofa/rpc/client/FailoverCluster.java (1)
`100-106`: The implementation for retrying on user-defined exceptions is correctly placed and follows logical exception handling practices.
core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json (1)
`174-175`: The addition of the `consumer.exceptions` configuration key is correctly implemented and allows for specifying user-defined exceptions as expected.
core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1)
`305-305`: The addition of the `CONSUMER_EXCEPTIONS` constant is correctly implemented and follows the existing conventions for configuration keys.
core/api/src/main/java/com/alipay/sofa/rpc/config/ConsumerConfig.java (1)
`40-40`: The addition of the static import for `getListValue` is appropriate for handling list configurations.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
stale[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.