sofastack / sofa-rpc

SOFARPC is a high-performance, high-extensibility, production-level Java RPC framework.
https://www.sofastack.tech/sofa-rpc/docs/Home
Apache License 2.0
3.81k stars 1.17k forks source link

add assertions to ConsulRegistryTest #414

Closed ScienJus closed 5 years ago

ScienJus commented 5 years ago

Your scenes

ConsulRegistryTest 需要一些断言确保能正确运行。

Your advice

每一个 CountDownLatch#await 都应该判断返回值为 true 确保 MockProviderInfoListener 收到了更新事件。

Environment

leizhiyuan commented 5 years ago

fix in https://github.com/sofastack/sofa-rpc/pull/629