search

sofastack / sofa-tracer

SOFATracer is a component for the distributed system call trace. And through a unified traceId logging the logs of various network calls in the invoking link. These logs can be used for quick discovery of faults, service governance, etc.
Apache License 2.0
1.11k stars 377 forks source link

fix ut issue #492

Closed nobodyiam closed 2 years ago

nobodyiam commented 2 years ago

Motivation:

Try to fix the ci failed issue.

Modification:

Use spring profile to set the config value.

Result:

Fixes #490.

codecov[bot] commented 2 years ago

Codecov Report

Merging #492 (1744699) into master (cdbde41) will increase coverage by 0.62%. The diff coverage is 76.08%.

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     46.30%   46.93%   +0.62%     
- Complexity      219      224       +5     
============================================
  Files           331      332       +1     
  Lines          9916     9946      +30     
  Branches        943      950       +7     
============================================
+ Hits           4592     4668      +76     
+ Misses         4840     4794      -46     
  Partials        484      484
Impacted Files Coverage Δ
...ource/tracer/DataSourceClientStatJsonReporter.java 94.11% <0.00%> (ø)
...atasource/tracer/DataSourceClientStatReporter.java 0.00% <0.00%> (ø)
...java/com/alipay/common/tracer/core/SofaTracer.java 71.97% <0.00%> (ø)
...er/core/configuration/SofaTracerConfiguration.java 77.46% <ø> (ø)
.../tracer/core/reporter/digest/DiskReporterImpl.java 90.74% <ø> (+3.70%) :arrow_up:
...at/manager/SofaTracerStatisticReporterManager.java 75.47% <60.00%> (-2.08%) :arrow_down:
...com/alipay/common/tracer/core/utils/DateUtils.java 75.00% <75.00%> (ø)
...acer/plugins/datasource/utils/DataSourceUtils.java 68.36% <81.48%> (+4.57%) :arrow_up:
...racer/core/context/span/SofaTracerSpanContext.java 79.22% <100.00%> (ø)
.../tracer/core/registry/AbstractTextB3Formatter.java 59.15% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nobodyiam commented 2 years ago

@glmapper

It looks like this pr fixes the ci failed issue. However, the code changes relate to the changes from #199 that you authored(original change1, original change2), would you please help to review?