search

sofastack / sofa-tracer

SOFATracer is a component for the distributed system call trace. And through a unified traceId logging the logs of various network calls in the invoking link. These logs can be used for quick discovery of faults, service governance, etc.
Apache License 2.0
1.11k stars 377 forks source link

fix unit tests #540

Open Just-CJ opened 2 months ago

Just-CJ commented 2 months ago

Motivation:

修复单元测试，主要修复tracer-sofa-boot-starter模块下单元测试不能正常运行的问题。

Modification:

  1. 调整embedmongo-spring为可选的编译期依赖，修复源码编译问题、
  2. 添加com.alipay.sofa:sofa-boot依赖 https://github.com/sofastack/sofa-tracer/pull/512 该pr中移除了infra-sofa-boot-starter依赖，这导致运行时缺少了com.alipay.sofa.boot.listener.SofaBootstrapRunListener，从而导致SofaTracerConfigurationListener无法正常的进行参数注入，测试用例无法正常执行。
image

项目正常依赖的sofaboot版本中，SofaBootstrapRunListener已经迁移到了com.alipay.sofa:sofa-boot中，不再需要依赖infra-sofa-boot-starter，重新将该依赖补回即可。

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request encompasses several updates primarily focused on dependency management within various pom.xml files and adjustments to Java test classes. Key changes include upgrading the mockito-core dependency from version 1.10.19 to 4.3.0, removing specific version declarations for mockito-core in multiple plugin projects, and refactoring import statements and class declarations to align with the updated package structure and functionality.

Changes

File Change Summary
pom.xml Updated mockito-core version from 1.10.19 to 4.3.0; removed version declarations in plugins.
BaseTest.java Updated import from org.mockito.runners.MockitoJUnitRunner to org.mockito.junit.MockitoJUnitRunner.
CountBenchmark.java Removed @Test annotation, indicating a shift to JMH for benchmarking.
tracer-sofa-boot-starter/pom.xml Added sofa-boot dependency; modified de.flapdoodle.embed.mongo version; marked embedmongo-spring as optional; added junit dependency for testing.
SofaTracerConfigurationListener.java Refactored method to use SofaBootEnvUtils for environment checks.
AbstractTestBase.java Updated import for SofaBootstrapRunListener to new package.
AbstractTestCloudBase.java Changed from concrete to abstract class; updated import for SofaBootstrapRunListener.
ConfigurationHolderListener.java Renamed import from SOFABootEnvUtils to SofaBootEnvUtils.
SpringBootWebApplication.java Excluded EmbeddedMongoAutoConfiguration from @SpringBootApplication.
ConfigurationTest.java Removed imports for Spring testing framework components.
tracer-test/core-test/pom.xml Removed version specification for mockito-core dependency, changing from 2.3.0 to unspecified.

Possibly related PRs

Poem

🐇 In the garden of code, changes bloom bright,
Mockito's new version, a delightful sight.
Dependencies dance, old paths now align,
Spring's gentle whispers, in tests they entwine.
With each little tweak, our code takes a leap,
Hopping towards clarity, in logic we keep! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.