search

soffes / SAMKeychain

Simple Objective-C wrapper for the keychain that works on Mac and iOS
MIT License
5.4k stars 956 forks source link

Nullability annotations for Swift not included #122

Closed codytwinton closed 8 years ago

codytwinton commented 8 years ago

Your framework rocks, but when using Swift I'm unsure if certain values can be nil. Could you add nullability annotations in your next release?

Thanks!

markcleonard commented 8 years ago

:+1: to this. Thanks @kenmaz.

soffes commented 8 years ago

PRs welcome :) The latest release adds generics which helps. I'd love to improve this though.

kenmaz commented 8 years ago

@soffes Merged latest master branch to my PR and resolved some conflicts. https://github.com/soffes/SAMKeychain/pull/131/commits/96a0814a2e91a9f36b592919ff175ec121772d22

Please merge me ! https://github.com/soffes/SAMKeychain/pull/131

soffes commented 8 years ago

Merged #131! Thanks @kenmaz! :heart: