search

soffes / SSPullToRefresh

Simple and highly customizable pull to refresh view
MIT License
885 stars 139 forks source link

Notify delegate about animations #25

Closed lbrndnr closed 11 years ago

lbrndnr commented 11 years ago

Here you go :) Hope you like it!

soffes commented 11 years ago

Thanks! I'll check it out when I get a second.

kvnsmth commented 11 years ago

@larcus94 Looks like a pretty cool addition.

Few things:

  1. Could you pull from master and make your changes again? The project now has a proper Xcode project, which should make your life easier.
  2. Make sure to add your delegate method to the delegate protocol in the optional section. (And document it, too. :)).
  3. Your fix for the warning is in master now with the latests.
lbrndnr commented 11 years ago

Yeah an Xcode project is a great idea to have included in the repo. Your second point was actually already the case so I didn't really change anything. Hope it's okay now.

lbrndnr commented 11 years ago

@kvnsmth So is my pull request okay or do I need to fix anything else?

soffes commented 11 years ago

Went ahead and implemented this: 8760bddd7ce063b73d7e5a67ac815ce766fea066