search

soflyy / breakdance-bugs

Bug reports from Breakdance users.
42 stars 6 forks source link

Unused Gravity Forms CSS Styles Present In Codebase #181

Closed thekendog closed 2 years ago

thekendog commented 2 years ago

From what I can tell, it looks like there is an attempt at styling Gravity Forms in the form.css file. However, it looks like the targeting isn't quite right. The CSS is looking for this for example...

.breakdance-form .gform_wrapper.gravity-theme .gfield input, .breakdance-form .gform_wrapper.gravity-theme .gfield textarea, .breakdance-form .gform_wrapper.gravity-theme .gfield select, .breakdance-form .breakdance-form-field__input

...but none of the Gravity Forms have the breakdance-form class on them. I tried putting that class on the shortcode wrapper but it caused an issue with the grid layout. Basically, it looks like the .breakdance-form part of the CSS targeting needs to be removed.

louisreingold commented 2 years ago

We considered building a gravity forms styler, and it may be available in the future, but it's not part of Breakdance currently.

We'll remove that code.

thekendog commented 2 years ago

Bummer, seems like the basic look and style and of the inputs and submit buttons could grab the styling somehow. Imagine it's gotta be hard to style for all form plugins though. Thanks for the response.

louisreingold commented 2 years ago

This will be cleaned up in the next beta.