Unable to close a popup if 'do not show this popup if an other popup has already shown'

soflyy / breakdance-bugs

Bug reports from Breakdance users.

42 stars 6 forks source link

Unable to close a popup if 'do not show this popup if an other popup has already shown' #887

Closed lockedm closed 1 year ago

lockedm commented 1 year ago

What version of Breakdance are you using?

For example: v1.4RC1

For example: macOS, Windows

create a popup
set do not show this popup if an other popup has already shown' to true
popup cannot be closed with the close button or by clicking off the popup

lockedm commented 1 year ago

Sorry, this looks to be an imcompatibiity with something within perfmatters. Disabling perfmatters and all is good.

lockedm commented 1 year ago

Actually, perfmatters is a red herring. can reproduce when perfmatters is disabled. It appears to be related to the number of triggers, or when using the trigger - page scroll - and then to a percentage. As you can see from this video, sometimes it works, but on the second time I'm clicking on the button and the background and it is not closing.

https://recordings.webxdesign.studio/recordings/Z8q2ABNPJ7FAtlqSGtDG

You should definitely be able to reproduce if you use these type of popup settings:

a-dubiel commented 1 year ago

Can you help me with triaging this? You have 5+ conditions on this popup. Which exact condition breaks the functionality?

lockedm commented 1 year ago

@a-dubiel if you look at the video, I've shown it with just 2 conditions like:

Refresh the page a couple of times with this in place and you can't close the popup. You can login to the same system as I've just emailed you for the breakpoint popup issue

lockedm commented 1 year ago

I can repro this with just a single trigger of 'page scroll' using percent. Using 'page scroll' to a specified selector appears to work OK. Spoke a bit too soon. page scroll with selector appears to work when there is only one trigger. When I added in exit intent and page load (10 secs) I was able to repro again.

a-dubiel commented 1 year ago

Awesome. I suspected these two triggers (scroll and exit) in conjunction cause errors. Thanks for the details. We are working on fixing this soon.

lockedm commented 1 year ago

That's great. Hope you've been able to repro it, otherwise log in to the site I emailed details for, and you'll see it.

      On Jul 12 2023, at 10:46 am, Andrzej Dubiel ***@***.***> wrote:

Awesome. I suspected these two triggers (scroll and exit) in conjunction cause errors. Thanks for the details. We are working on a fixing this soon.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

lockedm commented 1 year ago

This is fixed in 1.4.1 RC2. THanks.