soflyy / breakdance-bugs

Bug reports from Breakdance users.
42 stars 6 forks source link

Gallery loads full size images regardless of Image Size settings #889

Closed djrwp closed 1 year ago

djrwp commented 1 year ago

1.3.1 Chrome, Safari, macOS

I reported this bug via support last month but no sign of it here and not fixed in 1.4 rc.

Image Size settings are not respected in front end, the only one that works is thumbnail, all the others have no effect. This leads to a huge page size as full size images are loaded for every gallery image.

Screenshot 2023-07-09 at 08 53 49
louisreingold commented 1 year ago

Here's what's actually happening: https://www.loom.com/share/4cb9b0de9a8b486bb8267a2c7f346356

louisreingold commented 1 year ago

Removing the bug tag but leaving open as we might ship the option I proposed in the Loom.

But do you actually want this option?

louisreingold commented 1 year ago

Same thing happens with the Image element, yeah?

louisreingold commented 1 year ago

I reported this bug via support last month

@djrwp what's the ticket ID? I want to see if there's more info in the ticket.

louisreingold commented 1 year ago

Is there more to the issue than what I described above? If so, can you provide steps to reproduce? As you can see in my video, choosing a different size from the dropdown affects the image src attribute in the HTML, which is the correct behavior.

Is something different happening for you?

djrwp commented 1 year ago

Same thing happens with the Image element, yeah?

No, image element respects the chosen image size.

djrwp commented 1 year ago

I reported this bug via support last month

@djrwp what's the ticket ID? I want to see if there's more info in the ticket.

No ticket ID, but email was sent to support on 5th June, Subject - Gallery bug - loading full size images

djrwp commented 1 year ago

Here's what's actually happening: https://www.loom.com/share/4cb9b0de9a8b486bb8267a2c7f346356

that all makes sense, but in my browser it's loading full size 2560 width images which makes the initial page huge and slow to load even with lazy load. I take GTmetrix with a pinch of salt but the gallery page comes in at 27mb.

djrwp commented 1 year ago

Removing the bug tag but leaving open as we might ship the option I proposed in the Loom.

But do you actually want this option?

I think the option would be handy to override browser choice as regardless of users connection I wouldn't want to load full size images.

djrwp commented 1 year ago

Is there more to the issue than what I described above? If so, can you provide steps to reproduce? As you can see in my video, choosing a different size from the dropdown affects the image src attribute in the HTML, which is the correct behavior.

Is something different happening for you?

Pretty much as you describe, but this only happens with Gallery widget. In other widgets - image, loop builder, post loop the chosen image size is loaded.