soflyy / breakdance-bugs

Bug reports from Breakdance users.
40 stars 6 forks source link

ACF fields are not being imported into BD for selection when the ACF group field has a taxonomy condition #965

Open ninjaseo opened 11 months ago

ninjaseo commented 11 months ago

Problem

When there is an Advanced Custom Fields group with a visibility condition based on a taxonomy (e.g., a category), the fields do not appear on the dynamic selector inside BD.

Steps to reproduce

  1. Create a new group field in ACF with a simple text field.
  2. Add conditions to show this group on pages AND a category (e.g., category "custom").
  3. Create a new page and assign the category "custom" (in this example) to render the ACF group field there.
  4. Enter any text in the custom text field added by Advanced Custom Fields and save the page.
  5. Edit the page in Breakdance, add a text element and try to insert dynamic data into it.
  6. THE ACF GROUP AND FIELDS ASSIGNED DO NOT APPEAR in the "Insert Dynamic Data" popup.
  7. Go back to the group in ACF and change its visibility condition to only show on pages, removing the category condition, and save.
  8. Open the page again in BD and try to insert dynamic data.
  9. The ACF group now show up and you can select it.

This bug occurs in BD versions 1.5, 1.6 beta, and 1.6 RC-1. It occurs on PHP 7.4 and 8.0.

It is likely (not tested by me) that this bug also exists in earlier versions of BD, as another user reported the bug occurring in BD 1.4.1 in this thread: https://www.facebook.com/groups/breakdanceofficial/posts/6445886375446603/

Nicscott01 commented 6 months ago

I have encountered this same exact issue in BD 1.7.0 w/ ACF 6.2.6.1 & PHP8.2.