search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 29 forks source link

Conflict with WPMUDEV's Hummingbird (Pro) plugin. #1012

Open shoelaced opened 4 years ago

shoelaced commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

Activating "Asset Optimization" within Hummingbird Pro breaks the site. Here is what WPMUDEV's support said:

This is due to the Oxygen Builder Plugin causing a conflict with Hummingbird. The Oxygen builder plugin is using their own version of WP_Styles, all the styles/scripts are not registered via wp_enqueue_scripts or default WordPress functions which are causing the issue.

We’ll be looking to implement an integration regarding this down the plugin’s roadmap. In the meanwhile, I’m checking with our SLS team to see whether there is any quick patch that could be shared regarding this.

Will keep you posted once I get further feedback. Have a nice day ahead.

Although WPMUDEV is looking into whether they can do anything, it seems that if Oxygen is using such an unconventional approach to adding styles then there may be conflicts with other caching plugins as well, so I should think it'd be helpful for Oxygen to consider their approach to this too.

Have you tried all the steps at https://oxygenbuilder.com/documentation/troubleshooting/troubleshooting-guide/? Yes/No

Yes

Are you able to replicate the issue on a Sandbox install at https://oxygenbuilder.com/try?

Probably but you'd need to talk to WPMUDEV to get access to the Pro plugin as I'm not sure if the Asset Optimization option is available in the free version.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Activate Asset Optimization in Hummingbird Pro and then reload the site's homepage.

Expected behavior A clear and concise description of what you expected to happen.

Asset Optimization has a lot of potentially breaking features and one does need to be careful, but it should not be causing the site to break simply by activating it and before making any changes. It's also a powerful feature for site optimization, so it would be nice to be able to use it.

What actually happens A clear and concise description of what happens instead of the expected behavior.

The site's styles completely break.

shoelaced commented 4 years ago

Sorry, not sure why those sentences are large...

shoelaced commented 4 years ago

Update: WPMUDEV have created a quick mu-plugin as a workaround that has temporarily solved the issue: https://gist.github.com/wpmudev-sls/bd1a80a56cecb928dbf281f17f4de724