search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 29 forks source link

YoastSEO messed up Oxygen Gutenberg-Block with Slider-Content #1526

Open ghost opened 4 years ago

ghost commented 4 years ago

Describe the bug If using YoastSEO with a Gutenberg-Block "Slider" created with Oxygen-Builder, only the first slide shows up in the Gutenberg Editor. YoastSEO seems to disable the slide-jquery-function (class: ct-slider-script):

jQuery(document).ready(function($){$('#slider-3-7.ct_unique_slider_7903 .oxygen-unslider-container:not(.unslider-horizontal,.unslider-fade)').unslider({autoplay: false, delay: 3000, animation: 'horizontal', speed : 750, arrows: true, nav: true, infinite: false})});

If YoastSEO is disabled, everthing works fine!

Have you tried all the steps at https://oxygenbuilder.com/documentation/troubleshooting/troubleshooting-guide/? Yes

Are you able to replicate the issue on a Sandbox install at https://oxygenbuilder.com/try? Yes! http://courteous-tapir.w5.wpsandbox.pro?upass=5ed7C4yEdO3R

To Reproduce Steps to reproduce the behavior:

  1. Install and activate YoastSEO Plugin
  2. Create a new Oxy-Gutenberg-Block "Slider"
  3. Edit the Oxy-Block and create a slider-element with for example 3 slides
  4. Go to Page or Post, insert Oxy-Gutenberg-Block => only the first slide shows up

Expected behavior I can switch between Slides to edit them

What actually happens Only the first Slide shows up. The console shows an error: Uncaught TypeError: YoastSEO.app is undefined

Desktop (please complete the following information):

Additional context If i deactivate the Yoast-Plugin, the console Error is gone and everything works fine.

jeromeramone commented 4 years ago

I apologize in advance if I don't know the protocol here, since I don't know much about Git, just an early-2000s self-taught coder... but I might have an issue related to this one.

My client noticed that the "Text" tab on the Classic Editor on an "Edit Page" screen is no longer working. I looked at the page inspector, and saw this error: "Uncaught TypeError: YoastSEO.app is undefined"

I disabled Yoast, and the Text tab started working again.

I recently updated Yoast to version 14.9... this page was the only result when I googled the error.

It might be conflicting with "GoodLayers" which our theme uses. This is the full error text:

Uncaught TypeError: YoastSEO.app is undefined init https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1 e https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1

https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1 jQuery 4 i fireWith ready J page-builder.js:1:7203 init https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1 e https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1 https://www.[url redacted]/wp-content/plugins/goodlayers-core-ma/framework/js/page-builder.js?ver=1.4.0:1 jQuery 4 i fireWith ready J Again, sorry if I'm not supposed to put this here :) Please delete/disregard if it is irrelevant!
KittenCodes commented 4 years ago

@VF404 @jeromeramone These issues are caused by a change in Yoast 14.9. You should find that downgrading to 14.8 resolves the issue.

We are aware that Yoast have made a change to the way their plugin works and the issue has been reported internally.