search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 29 forks source link

Attributes cannot be applied to when styling the output of a codeblock #1550

Open damienlee77 opened 4 years ago

damienlee77 commented 4 years ago

Describe the bug I have been trying to make use of the fantastic new addition of attributes that I was eagerly awaiting to achieve many tasks. However, it's not working for styling the output of codeblocks which is my main usecase. So its of limited value. In my case, I was looking to apply data attributes to a canvas element. I'm using a canvas element to provide gauge graphic and I wanted to be able to provide its value from an acf field. While I can set an attribute name and value manually, it will not load on the front end. Using the dynamic data button doesn't work either.

To Reproduce Steps to reproduce the behavior:

Add a simple codeblock with a div inside it and then try to style to output div and add an attribute. No result will appear on the front end and its impossible to use dynamic data.

Expected behavior It should work!!! ;)

Spellhammer commented 4 years ago

The Selector Detector manipulates CSS, e.g. selectors, by allowing you to add/change CSS properties via the GUI. It makes sense that you can't add HTML attributes via CSS. We should probably hide the Attributes options on Selectors.

damienlee77 commented 4 years ago

The Selector Detector manipulates CSS, e.g. selectors, by allowing you to add/change CSS properties via the GUI. It makes sense that you can't add HTML attributes via CSS. We should probably hide the Attributes options on Selectors.

Accepted, attributes are not css, but should be able to be injected into the dom? It should be possible, though perhaps its not a high priority and thus should be hidden in the meantime. This would be extremely useful, however.

A workaround which would achieve the same objective might be for Oxygen to support all dom objects such as "canvas", "svg", "path" etc which would allow me to assign attributes to these elements. This approach is somewhat more limiting, but perhaps requires no real coding work to achieve, but simply allowing for these dom elements to be assigned.