search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
315 stars 30 forks source link

ACF Integration #2810

Open robertopib opened 2 years ago

robertopib commented 2 years ago

Oxygen 4.0 Beta 1 & 2 Custom Post Type UI Version 1.11.2 Advanced Custom Fields PRO Version 5.11.4

Trying to display dynamic data from ACF on a repeater, it gets displayed in the builder editor but on the front end the following Notice message gets displayed:

Notice: Trying to access array offset on value of type bool in /var/www/html/wordpress/wp-content/plugins/oxygen/component-framework/includes/acf/oxygen-acf-integration.php on line 927

Steps to reproduce the behavior:

  1. Create Custom Post Type and Custom Fields with CPTUI and ACF
  2. Create a repeater element on the CPT archive template
  3. Map custom fields
  4. Load Frontend
KittenCodes commented 2 years ago

@robertopib I've not yet been able to replicate this.

Please could you let me know which type of ACF field(s) you're using?

mrogaar commented 2 years ago

@KittenCodes I just received this error aswell after making a group field. afbeelding

ondiego commented 2 years ago

Oxygen 3.9 Advanced Custom Fields 5.12.2 CPT UI 1.12.0

I have the same problem on Oxygen 3.9 with a 2GB log in less than 24 hours. Please fix this.

Oxygen ACF Integration Issue

BrianHenryIE commented 2 years ago

PHP Warning: Trying to access array offset on value of type bool in /path/to/wp-content/plugins/oxygen/component-framework/includes/acf/oxygen-acf-integration.php on line 676

KittenCodes commented 2 years ago

Is anyone able to reproduce this on our Sandbox site?

aadlung commented 11 months ago

This only happens if you have an ACF integration, and in my case the ACF File Field is empty (no file attached). I can reproduce it. But as it's more than a year old I assume nobody will have a look at it - even if clean code should not produce PHP warnings.

So all needed to solve this is to add an additional check if there is a value. Is there no Github Repo where we can add Pull Requests?

Before: } else { After } else if($field['value']) {

2023-10-04 at 09 56

Kpudlo commented 9 months ago

Thanks @aadlung - replicated and reported internally via https://github.com/soflyy/oxygen/issues/5127.

Is there no Github Repo where we can add Pull Requests?

No, there is no repo available for pull requests at this time.