soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 29 forks source link

4.0 beta 2 - Two nestable components breaks repeater if using dynamic data in repeater #2821

Open wplit opened 2 years ago

wplit commented 2 years ago

This is in related to API components, I made a quick fork of Elijah's example plugin, which is needed so there's two nestable components instead of one - https://github.com/wplit/example-oxygen-api-plugin

What happens is.. if there are two nestable elements in a template, and a page uses that template and adds a repeater.. when the user adds dynamic data to the repeater there is an error. "TypeError: Cannot read properties of undefined (reading 'name')" and that element becomes uneditable.

Here's a sandbox site showing the issue with a loom video just showing the error happening..

Username: admin password: 7oK)mseRdCZg@rox617%#aZR https://oxygen-qrawrrxkmxnll.oxygen-demo.qsandbox.me/

video following the steps and showing the issue - https://www.loom.com/share/a609f3967f084121ab78e23a13316e3a

Exact steps to reproduce..

wplit commented 2 years ago

Update - the issue only shows up if using repeater in normal mode, not single mode.

Also, changing the nestable component to be a reusable template prevents it also.

Lastly, visiting the page with just ?ct_builder=true (instead of ?ct_builder=true&ct_inner=true) to prevent the inheriting template from being shown, also prevents it.

I'll sneak a feature request in here as it's related.. why not have a setting where the 'edit with oxygen' button that only loads in the current page and none of the inherited templates. so it's never including the '&ct_inner=true', even if just for performance, where there's no need to keep loading up the entire site.

KittenCodes commented 2 years ago

@wplit Thank you for writing such easy to follow and concise bug reports. It really is appreciated.

Replicated and reported internally.