search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 29 forks source link

There are multiple title tags because of using older version of Fontawesome. #3435

Open hellobubai opened 1 year ago

hellobubai commented 1 year ago

Hey there, To recreate the issue:- Go to any website that you created using oxygen and which is using fontawesome icons. it will display this kind of html in the structure.

arrow-down

I want to bring your attention to a issue of oxygen builder websites. So when you create any website with oxygen there are multiple title tags outside of oxygen. It's because Oxygen is using older version of oxygen builder. Probably >= 5.8.0 because its maintainers (after a long discussion:)), agreed that the "title" should be removed from the svg files and it's done in v. 5.8.0 : https://github.com/FortAwesome/Font-Awesome/issues/14595

Multiple title tags doesn't effect much on the seo part but some client don't want multiple title tags and they want us to remove the title tags and there is no other way to remove them as we don't have access to them.

Can you please take a look in to this matter and make sure the svg files don't have title tags.

maltmann-muc commented 11 months ago

HTML does only allow one title tag in the head section of a page. The title tags you're seeing are in the svg defs section and are totally valid.

This topic is NOT related or limited to Font Awesome icons only, but also concerns Linear Icons and custom icon sets. It's more the general way of icon handing in Oxygen. Even with a newer version of Font Awesome, Oxygen would absolutely need the icon titles internally to be able to search for icons.

While those titles are needed in Builder to search for icons, the tags in the SVG definitions are not needed in frontend. I agree that they could and should be removed when emitting the SVG defs to the frontend.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>