soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
315 stars 31 forks source link

Provide a Mandatory Blank Theme and Stop Faking the Theme #3529

Open maltmann-muc opened 2 months ago

maltmann-muc commented 2 months ago

Preface: Oxygen "disables" the active theme by manipulating the theme name to "oxygen-is-not-a-theme", and changing the template and stylesheet paths to "fake". This worked in the past with the older, simpler themes.

Since WordPress introduced Full Site Editing themes, there are many more steps involved in theme initialization, like the theme.json, the blocks configurations, and many more. This causes issues with the default themes like "Twenty Twenty-Two", "... -Three", "...-Four", and the recommendation is to activate an older or a blank theme. One example that comes to my mind is theme "Twenty Twenty-Four" that tries to load font "Inter", included in the theme's assets folder, via theme.json. Since the theme name and path is invalidated by Oxygen, the access to the font causes a 404 error in frontend. The last WordPress update to 6.5.2 is now causing even more issues, especially with custom Gutenberg Blocks that utilize features like script, editorScript, style, editorStyle, ... See ticket #3525 It's pretty foreseeable that future WordPress, Theme, and Gutenberg updates will cause even more unexpected issues.

Dozens of issues reported in the Facebook group are caused by Oxygen's theme faking in conjunction with FSE themes and the newer Gutenberg Block features.

Request: Instead of trying to disable a theme's influences, and trying to keep up with changes in recent WordPress versions,

Advantages & Benefits:

perrelet commented 2 months ago

This. @maltmann-muc to the moon 🚀🤘👩‍🚀

shoelaced commented 2 months ago

Though technically it doesn't matter, semantically it is strange that Oxygen is a plugin instead of a theme in the first place, given that it effectively functions as one. An official blank theme would be a welcome standardized way to ensure everyone is running the same theme environment. My only feedback would be that I personally use a blank theme I created specifically so that I can control theme.json to enable/disable options in Gutenberg. I would not want to lose that capability, so I'd support this move as long as some consideration goes into that -- either by creating a theme.json editor of some kind in Oxygen, or by implementing this in a way that allows a child theme as Matt mentioned.

perrelet commented 2 months ago

@shoelaced Absolutely, in this case theme.json can simply be defined in the child theme, overriding parent settings and styles.

22onn22 commented 1 month ago

You got my vote.

jorgeiglesiasca commented 1 month ago

mi vote

isatisfy commented 1 month ago

👍

lucianahanan commented 1 month ago

up

galliweb commented 1 month ago

This! And we are even more flexible in working with Oxygen. Makes a great tool even greater and much less annoying for some tasks. No need to hack around with own workarounds any longer.

MrMasterKey commented 1 month ago

Upvoted.