search

soflyy / oxygen-bugs-and-features

Bug Reports & Feature Requests for Oxygen
https://oxygenbuilder.com/
314 stars 31 forks source link

Links inside Gutenberg blocks are badly generated and don't work in subpages #823

Open yankiara opened 4 years ago

yankiara commented 4 years ago

Describe the bug Links inserted in Gutenberg blocks are wrong because they all start with ".." on frontend. Thus, they don't work on pages that are not at root level.

Have you tried all the steps at https://oxygenbuilder.com/documentation/troubleshooting/troubleshooting-guide/? Yes

Are you able to replicate the issue on a Sandbox install at https://oxygenbuilder.com/try? Yes https://oxygen-qgxcp27f72w7k.oxygen-demo.qsandbox.me

To Reproduce Steps to reproduce the behavior:

  1. Add a page (name it Subpage for instance) with parent page Sample Page
  2. Add a new Oxygen block (name it Test block) with Rich text element
  3. Edit "Subpage", add a link in paragraph
  4. Add a "Test block", edit it and add a links inside
  5. Save and check Subpage on frontend

Expected behavior Links should all start with "/" and should be relative to site root.

What actually happens The links inside the Gutenberg block are wrong because they all start with "../". So they only work on pages at the root level.

Screenshots gutenberg block link gutenberg block link 2 gutenberg block link 3

Desktop (please complete the following information):

Spellhammer commented 4 years ago

Replicated & reported internally.

maltmann-muc commented 4 years ago

Have the same problem currently in a project. That makes the use of Gutenberg blocks with links impossible.

wpsumo commented 4 years ago

Would prefer absolute paths instead of relative.

dlovere commented 3 years ago

This is a pressing concern for me in a major project. Would love to see some attention on this.

lbdsgn commented 3 years ago

Soflyy, this is embarrassing for a product building its reputation on deep Gutenberg integration.

dlovere commented 3 years ago

This bug is resolved by adding the following at line 259 of oxygen-gutenberg.js (the config section for TinyMCE): relative_urls : false,

Airbees commented 3 years ago

Soflyy, please fix this!!!!!

13robin37 commented 3 years ago

This bug is resolved by adding the following at line 259 of oxygen-gutenberg.js (the config section for TinyMCE): relative_urls : false,

This worked for me. Although this isn't update proof which makes it a PITA.

jevgen commented 3 years ago

This bug is resolved by adding the following at line 259 of oxygen-gutenberg.js (the config section for TinyMCE): relative_urls : false,

This worked for me. Although this isn't update proof which makes it a PITA.

This does not look like a permanent solution. There has to be a wider one addressing this issue along with that one: https://github.com/soflyy/oxygen-bugs-and-features/issues/255

dasgelbevomei commented 1 year ago

This bug is resolved by adding the following at line 259 of oxygen-gutenberg.js (the config section for TinyMCE): relative_urls : false,

Seems not to work anymore.