search

sofn-xyz / mailing

Build, test, send emails with React
https://www.mailing.run
MIT License
3.6k stars 74 forks source link

Install instructions don't work with yarn 3 #286

Open maxsalven opened 1 year ago

maxsalven commented 1 year ago 
yarn init -2
yarn add react react-dom
yarn add mailing mailing-core next
❯ npx mailing
npm ERR! could not determine executable to run
❯ yarn mailing
/Volumes/Development/redacted/mailing/.pnp.cjs:14997
      Error.captureStackTrace(firstError);
            ^

Error: mjml-react tried to access html-minifier, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: html-minifier
Required by: mjml-react@virtual:6d81881a1bfe24e2cd76906e9d9981397267cb7fc03bc23d78149550c280613688d0e698048cf858b183cac3c2f546c8931986bfb167052b95f4980d66c4cbbc#npm:2.0.8 (via /Volumes/Development/redacted/mailing/.yarn/__virtual__/mjml-react-virtual-6891c6d534/0/cache/mjml-react-npm-2.0.8-3f1f55c156-595525af54.zip/node_modules/mjml-react/dist/src/)

Everything works fine with yarn 1.

psugihara commented 1 year ago

Thanks for opening an issue @maxsalven and sorry about that. Would love to support yarn 3 if any outside contributors have time to work on this. It's on our list but not high priority at the moment because it seems like most people are still on yarn 1.

If someone figure out how to support, it should be easy to add an e2e test suite for it (@alexfarrill and @elliothursh can help there).