Welcome template - Githubissues

sofn-xyz / mailing

Build, test, send emails with React

https://www.mailing.run

MIT License

3.6k stars 74 forks source link

Welcome template #416

Closed elliothursh closed 1 year ago

elliothursh commented 1 year ago

Describe your changes

Adds new Welcome template.

Issue link

N/A

Checklist before requesting a review

[X] I have performed a self-review of my code
[X] If it is a core feature, I have added thorough tests.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3dc1c6d3cd56e57312903c8b10f76eebd512b0ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------ | ----- | | mailing | Patch | | mailing-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
mailing-dynamic-demo	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 9:08PM (UTC)
web-emails	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 9:08PM (UTC)

1 Ignored Deployment

| Name | Status | Preview | Updated | | :--- | :----- | :------ | :------ | | **web** | ⬜️ Ignored ([Inspect](https://vercel.com/sofn/web/7zqtGcFiSg973Ut8g6nnPjURSoAQ)) | | Dec 12, 2022 at 9:08PM (UTC) |

elliothursh commented 1 year ago

@monicakogler can you give this a pass when you have a minute? https://mailing-dynamic-demo-git-welcome-template-sofn.vercel.app/previews/Welcome/preview

monicakogler commented 1 year ago

cool looks good, just a few little things please:

[x] idk if it's just me but the the font weight in the logo looks light, could we use this one?
[x] bold "The open source platform..." in header
[x] capitalize D in "Check out the Docs"
[ ] will the newsletter show up in this list too? i think it probably should? and in that case could we match how the bg works there? like the email body bg is our black (111) and then the background of the page is true black (000)?
[x] when we were building the homepage we decided to style code like it is in the docs – smaller font with a background color (see MDX Code component)... is it easy enough to style like that in the email?

ty 🙏🙏🙏

elliothursh commented 1 year ago

The Newsletter won't show up by default in these emails, I can copy it over if we want though. I will match the backgrounds for now.