search

sofn-xyz / mailing

Build, test, send emails with React
https://www.mailing.run
MIT License
3.61k stars 72 forks source link

Production builds still try to live reload #438

Closed oliverzheng closed 1 year ago

oliverzheng commented 1 year ago

Describe the bug In the developer console, I can see socket.io network requests being sent for a production build. E.g. on https://book-book-mailing.vercel.app/

To Reproduce Steps to reproduce the behavior:

  1. Go to https://book-book-mailing.vercel.app/previews/Reservation/reservationWithError
  2. Open dev console
  3. See network requests for pulling.

Weirdly, only some of the demos on the Mailing website experience this.

Expected behavior No live reload happens on production build.

Screenshots

image

Desktop (please complete the following information):

Additional context

psugihara commented 1 year ago

Good catch. Let's remove that by checking if NODE_ENV === "production"

marcincodes commented 1 year ago

@psugihara This issue can be closed. Fix was merged here: https://github.com/sofn-xyz/mailing/pull/483