Closed m5r closed 1 year ago
Latest commit: ae5b3be72b6bde5c802646e73e9a6ef079f47109
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@m5r is attempting to deploy a commit to the sofn Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
mailing-dynamic-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 3, 2023 at 7:59PM (UTC) |
mailing-web | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 3, 2023 at 7:59PM (UTC) |
web-emails | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 3, 2023 at 7:59PM (UTC) |
Describe your changes
A third attempt at #222 and #224
I ran into some types issues where
@faire/mjml-react
was less permissive with props likepadding
,fontWeight
orfontSize
so I converted values where needed (e.g.padding: 0
=>padding: "0px"
). There is a discussion about this in https://github.com/Faire/mjml-react/pull/81Issue link
203
Checklist before requesting a review