sofn-xyz / mailing

Build, test, send emails with React

https://www.mailing.run

MIT License

3.6k stars 74 forks source link

replace `mjml-react` with `@faire/mjml-react` and fix types issues #453

Closed m5r closed 1 year ago

m5r commented 1 year ago

Describe your changes

A third attempt at #222 and #224

I ran into some types issues where @faire/mjml-react was less permissive with props like padding, fontWeight or fontSize so I converted values where needed (e.g. padding: 0 => padding: "0px"). There is a discussion about this in https://github.com/Faire/mjml-react/pull/81

Issue link

203

Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ae5b3be72b6bde5c802646e73e9a6ef079f47109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ------------ | ----- | | mailing | Minor | | mailing-core | Minor | | web | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

@m5r is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
mailing-dynamic-demo	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 3, 2023 at 7:59PM (UTC)
mailing-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 3, 2023 at 7:59PM (UTC)
web-emails	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 3, 2023 at 7:59PM (UTC)