sofn-xyz / mailing

Build, test, send emails with React
https://www.mailing.run
MIT License
3.6k stars 74 forks source link

replace mjml-react with @faire/mjml-react and fix types issues (alex version, clean) #461

Closed alexfarrill closed 1 year ago

alexfarrill commented 1 year ago

adds 2 tweaks to @faire/mjml-react

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: fe518565e8b48508cbd96b4dcd7cd37fdc5d48cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------ | ----- | | mailing | Minor | | mailing-core | Minor | | web | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mailing-dynamic-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 10:20pm
mailing-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 10:20pm
web-emails ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 10:20pm
m5r commented 1 year ago

Hey, any update about this? It looks like the e2e tests are passing finally :smile:
Let me know if there is anything else I can do to help get this merged

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@faire/mjml-react@3.1.2 None +6 ianedington
psugihara commented 1 year ago

released this as 1.0.0-next.0

we'll try it in production on iterate.world for a bit before merging :)

alexfarrill commented 1 year ago

The redwood_ts test is also failing in master and is unrelated to the changes in this branch I believe. (In both branches it's complaining about the yarn version used to run create-redwood-app)

psugihara commented 1 year ago

We've been running this in prod on iterate.world for a week. Seems good 👍, let's merge monday.

alexfarrill commented 1 year ago

@m5r this has been release in Mailing 1.0.0. Thanks again for the great work here 🥇 !

m5r commented 1 year ago

@alexfarrill thanks a lot for taking the time to push this one through :heart: