Sidebar sometimes disappears and gets stuck in faulty state - Githubissues

sofn-xyz / mailing

Build, test, send emails with React

https://www.mailing.run

MIT License

3.6k stars 74 forks source link

Sidebar sometimes disappears and gets stuck in faulty state #464

Closed KATT closed 10 months ago

KATT commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce

Repro at https://github.com/KATT/mailing-run-issue

Steps to reproduce the behavior:

git clone git@github.com:KATT/mailing-run-issue.git
cd mailing-run-issue
yarn
npx mailing

Click Welcome -> Preview email
Reload page

Expected behavior

Should look the same.

Actual behavior

Sidebar disappears
Gets stuck in faulty state even if you clear the URL

Workaround: clear the URL except for the /preview part

Video

https://user-images.githubusercontent.com/459267/230070695-4a94812d-43da-43bb-bada-e2d7a471d5dc.mp4

Additional context:

Might be because of the space here: https://github.com/KATT/mailing-run-issue/blob/aa8fb7744a0c8e13a28198355906c9aae636dbcb/emails/previews/Welcome.tsx#L4

marcincodes commented 10 months ago

@psugihara This issue can be closed. Fix was merged here: https://github.com/sofn-xyz/mailing/pull/482