mailing should early return if api returns a non 200 code

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: cd1cb9788ceeb9b521240751f414b4655bab951e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ------------ | ----- | | mailing-core | Patch | | mailing | Patch | | web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mailing-dynamic-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2023 9:38pm
web-emails	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2023 9:38pm

1 Ignored Deployment

alexfarrill commented 1 year ago

not gonna debug this rn, but redwood_ts is failing because below. error message makes no sense as yarn 1.22.19 >= 1.15.0

yarn create redwood-app testme --typescript --no-git
yarn create v1.22.19
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...

success Installed "create-redwood-app@5.0.3" with binaries:
      - create-redwood-app
[################################################################################################################################################################################################################] 993/993------------------------------------------------------------------
                🌲⚡️ Welcome to RedwoodJS! ⚡️🌲
------------------------------------------------------------------
┌ ⚠ Error: Compatibility checks failed ──────────────────────────────────────────────────────────────┐
│                                                                                                    │
│       yarn >=1.15.0 required; found 1.22.19                                                        │
│                                                                                                    │
│     Please use tools like nvm or corepack to change to a compatible version.                       │
│     See: Tutorial - Prerequisites (https://redwoodjs.com/docs/tutorial/chapter1/prerequisites)   │
│                                                                                                    │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘
error Command failed.
Exit code: 1
Command: /Users/alexfarrill/.asdf/installs/nodejs/16.19.0/.npm/bin/create-redwood-app
Arguments: testme --typescript --no-git
Directory: /private/tmp/mailing_e2e/runs/20230503145002
Output:

info Visit https://yarnpkg.com/en/docs/cli/create for documentation about this command.

sofn-xyz / mailing

mailing should early return if api returns a non 200 code #467

🦋 Changeset detected