Bad conditional when added error message

sofn-xyz / mailing

Build, test, send emails with React

https://www.mailing.run

MIT License

3.6k stars 74 forks source link

Bad conditional when added error message #494

Closed potofpie closed 3 months ago

potofpie commented 4 months ago

Describe your changes

Currently the error will always be request body without the additional text. I believe the intension of the code was to append "querystring" or "request body" depending on the method.

Issue link

I discovered this issue while trying to debug another issue and did not understand why I was getting a error message about the body when I was sending a GET request.

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] If it is a core feature, I have added thorough tests.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: e49277e8c73fe7a112ba7a18c0fb910c15aa272e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR