search

sofroniewn / tactile-coding

Notebooks to accompany sofroniew-vlasov-2015
9 stars 4 forks source link

error generating ISIs #1

Open jsseely opened 8 years ago

jsseely commented 8 years ago

When generating the ISIs in the ephys-traces notebook, this command

units = units.join(pd.DataFrame({'rateFA':[getSpikeISI(x,threshFA)[3] for x in units.sourceId]}))

returns this error

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-37-5c33675b52f6> in <module>()
----> 1 units = units.join(pd.DataFrame({'rateFA':[getSpikeISI(x,threshFA)[3] for x in units.sourceId]}))

<ipython-input-35-ba0326ca444b> in getSpikeISI(sourceId, threshFA)
      7     peakTimeISI = timesISI[ISI.argmax()]
      8     timesISI = timesISI[:-1]
----> 9     timesISI = np.concatenate((-np.fliplr([timesISI])[0],timesISI[1:]),axis = 1)
     10     ISI = np.concatenate((np.fliplr([ISI])[0],ISI[1:]),axis = 1)
     11     return timesISI, ISI, peakTimeISI, rateFA

IndexError: axis 1 out of bounds [0, 1)

This is using pandas 0.18.0 and numpy 1.10.4, which are slightly more recent than the ones used in the repo / binder, which could be the source of the problem.

The best solution would be to test locally with those versions, confirm the error is fixed, then bump the dependencies and regenerate the Binder.

sofroniewn commented 8 years ago

Ok thanks, I'll look into it