Open Dave89rr opened 8 years ago
Do the same in google maps and you find the same oddities. Thanks for bringing it up.
@Knagus I did those searches both in your app and in google, but I don't know what oddities you're referring to? Is there a specific link you have for google that I could test that says "yes" v "no"? When I looked it up I only saw miles and multiple options for routes.
The way the app is supposed to be coded is this: Three separate queries are made to google. A) Find the driving time from the driver to rider. B) Find the driving time from the rider to GGC. C) Find the driving time from the driver to GGC. If A + B <= C + 10 minutes, the result should be yes. Otherwise, no. One issue might be that you used "1000 University Center Lane," whereas I used "Georgia Gwinnett College." According to Google, they're a 2 minute walk apart. It's also possible that I have drivers and riders switched somewhere in the code. I'll double check. It also looks like there might be slight discrepancies checking against Google Maps because it rounds the results. So a driving time of 12.5 minutes might be displayed as 13 minutes.
Thanks for the testing. Very helpful!
@mstackpo I think that might be the case that you do have the driver and rider switched. It would explain why Tests' 5 & 6 results (Yes v No) were reversed. Edit: Although it wouldn't explain why Tests' 7 & 8 results were correct. :/
Is Rider Close Enough for Ride?
Of the tests I did, I decided to record these 8 here, because some of the results were confusing.
Tests not shown here included opposite sides of GGC, in which case flipping the address didn't change the result. Given that the driver and rider were within certain threshold the system consistently gave "yes" and outside that threshold it gave "no"