Closed charlesreid1 closed 6 years ago
This pull request will be updated as follows:
Uncovered another issue while updating these notebooks - installing trackpy from pip implements a legacy link_df()
interface, where there is a diagnostics
parameter, but this interface breaks when using trackpy installed from the github repository. See #45 for proposed fix, implemented in this PR.
Wow, thanks for taking the time for do this @charlesreid1. I appreciate the granular commits.
I would also be happy to export them to HTML, add them to the soft-matter.github.io trackpy page, and send a pull request for that repo as well.
The HTML will be automatically generated and push into the docs repo when this PR is merged, so no separate PR into the docs repo is needed. Thanks for the offer to present a more reviewable form. I'm content to build it locally and take a look. Will give this a detailed review today or tomorrow.
So sorry for letting this languish so long, @charlesreid1. Merging!
No problem. Thanks for the pull!
This pull request contains a substantial number of changes, but the substance of the notebooks has been preserved in each case. The main changes in this pull request are:
threshold_adaptive()
function in scikit-image) and updated mentions of old versions of software (e.g., ipython-parallel)There are also cosmetic changes caused by changes to modules/libraries since the last time these notebooks were updated (e.g., output of
timeit
commands or ipython notebooks lacking a "collapsed" state).Please comment on anything that you have doubts about or wish to discuss. When you're okay with these updates and they've been merged, I would also be happy to export them to HTML, add them to the soft-matter.github.io trackpy page, and send a pull request for that repo as well.