Change minimum versions and remove compatibility fixes

soft-matter / trackpy

Python particle tracking toolkit

http://soft-matter.github.io/trackpy

Other

442 stars 131 forks source link

Change minimum versions and remove compatibility fixes #656

Closed caspervdw closed 3 years ago

caspervdw commented 3 years ago

Closes #645 and #655

caspervdw commented 3 years ago

I am afraid that the doc build might fall apart if I touch it... Maybe better to leave Py3.5 in after all for this release, and only fix #655 in v0.5? What do you think?

rbnvrw commented 3 years ago

I've tried building the docs locally on Python 3.8.6 and that worked without problem, so I'm not sure why you think they'd break? While building the docs, I found that we don't have a toctree that includes the full API, so I've added it in this PR: #658 Probably not crucial to have, but maybe a good idea for discoverability of functions that are not included in the main API document.

caspervdw commented 3 years ago

I am mostly concerned about the notebooks. But let's see what happens.

caspervdw commented 3 years ago

Everything seems to be in order with the new doc (and notebook) env. @nkeim could you also take a look at http://soft-matter.github.io/trackpy/dev/ ?

There still are a couple of warnings in the doc generation. I am ok leaving that for now, but if someone could make time to fix them... preferably I like to build docs with “warn-as-error” and use a separate GH actions runner to check them.

nkeim commented 3 years ago

Looks great!! Thanks, @caspervdw and @rbnvrw ! It feels so good to drop all that compatibility code…