softScheck / tplink-smartplug

TP-Link WiFi SmartPlug Client and Wireshark Dissector
Apache License 2.0
1.15k stars 297 forks source link

Extraneous 'f' in tplink_smartplug.py causing Python error #84

Closed Maxhawkgt closed 3 years ago

Maxhawkgt commented 3 years ago

Just tried this script for the first time and got Python errors. Digging into the code turned up an extra character in lines 90 and 135 causing the issue. I removed the extra 'f' and now it works. I apologize if I'm not using the proper way to push suggested changes (aka I'm a github noob).

parser = argparse.ArgumentParser(description=f"TP-Link Wi-Fi Smart Plug Client v{version}")

quit(f"Could not connect to host {ip}:{port}")

Jeppedy commented 3 years ago

That is a formatted string part of later versions of Python...

On Tue, Dec 8, 2020, 12:27 Maxhawkgt notifications@github.com wrote:

Just tried this script for the first time and got Python errors. Digging into the code turned up an extra character in lines 90 and 135 causing the issue. I removed the extra 'f' and now it works. I apologize if I'm not using the proper way to push suggested changes (aka I'm a github noob).

parser = argparse.ArgumentParser(description=f"TP-Link Wi-Fi Smart Plug Client v{version}")

quit(f"Could not connect to host {ip}:{port}")

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/softScheck/tplink-smartplug/issues/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB32XY5IGAYII4NHNVFNCQ3STZVXTANCNFSM4USLJ6KA .